wankunde opened a new pull request #524: [GRIFFIN-281] Add custom sink test URL: https://github.com/apache/griffin/pull/524 Add custom sink test. I also have two question: 1. In `ConsoleSink`,`ElasticSearchSink`,`MongoSink` , the `sinkRecords` method doesn't really sink records ? 2. Why should we have four metrics output types ? ``` * flatten: Aggregation method used before sending data frame result into the sink: - default: use "array" if data frame returned multiple records, otherwise use "entries" - entries: sends first row of data frame as metric results, like like `{"agg_col": "value"}` - array: wraps all metrics into a map, like `{"my_out_name": [{"agg_col": "value"}]}` - map: wraps first row of data frame into a map, like `{"my_out_name": {"agg_col": "value"}}` ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
