[
https://issues.apache.org/jira/browse/GRIFFIN-283?focusedWorklogId=299486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299486
]
ASF GitHub Bot logged work on GRIFFIN-283:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/19 14:57
Start Date: 22/Aug/19 14:57
Worklog Time Spent: 10m
Work Description: bhlx3lyx7 commented on pull request #526: [GRIFFIN-283]
Move sink steps into TransformStep
URL: https://github.com/apache/griffin/pull/526#discussion_r316726494
##########
File path:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/Expr2DQSteps.scala
##########
@@ -32,6 +33,10 @@ trait Expr2DQSteps extends Loggable with Serializable {
def getDQSteps(): Seq[DQStep]
+ implicit def recoredWriteStepToList(writeStep: RecordWriteStep):
List[WriteStep] = writeStep :: Nil
+
+ implicit def metricsWriteStepToList(writeStep: MetricWriteStep):
List[WriteStep] = writeStep :: Nil
Review comment:
It's a little weird to implicitly change a `WriteStep` into
`List[WriteStep]`, it would be clearer and easier for reading if we just pass
the List parameter as the function defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 299486)
Time Spent: 20m (was: 10m)
> Move sink steps into TransformStep
> ----------------------------------
>
> Key: GRIFFIN-283
> URL: https://issues.apache.org/jira/browse/GRIFFIN-283
> Project: Griffin
> Issue Type: Task
> Reporter: wan kun
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Treat sink steps as a part of a transform step, so we can keep focus on
> transform step codes.
> Also the sink steps and some other transform step could be executed
> concurrently.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
