[ 
https://issues.apache.org/jira/browse/GRIFFIN-290?focusedWorklogId=312764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312764
 ]

ASF GitHub Bot logged work on GRIFFIN-290:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Sep/19 02:58
            Start Date: 16/Sep/19 02:58
    Worklog Time Spent: 10m 
      Work Description: wankunde commented on pull request #534: 
[GRIFFIN-290]Fix bug for submitting job to livy
URL: https://github.com/apache/griffin/pull/534#discussion_r324499467
 
 

 ##########
 File path: 
service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java
 ##########
 @@ -204,6 +204,7 @@ private void setLivyArgs() throws IOException {
         args.add(finalMeasureJson);
         args.add("raw,raw");
         livyConfMap.put("args", args);
+        livyConfMap.remove("name");
 
 Review comment:
   @guoyuepeng 
   Instead of hard coding,we can explicitly specify the livy session name in 
the  configuration file. which is null by default.
   
   Or we can use the DQ job name to be the livy session name?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 312764)
    Time Spent: 0.5h  (was: 20m)

> Fix bug for submitting job to livy
> ----------------------------------
>
>                 Key: GRIFFIN-290
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-290
>             Project: Griffin
>          Issue Type: Task
>            Reporter: wan kun
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When griffin submit multiple DQ jobs to livy, the http parameter `name` is 
> always griffin. 
>  So livy will reject them.
> job request :
>  
> {quote}[owner: null, request: [proxyUser: None, file: 
> hdfs://nameservice-standby/user/kun.wan/measure-0.6.0-SNAPSHOT.jar, 
>  args: {
>  "spark" :
> Unknown macro: \{ "log.level" }
> ,
>  "sinks" : [
> Unknown macro: \{ .... }
> ],
>  "griffin.checkpoint" : [ ]
>  },{
>  "measure.type" : "griffin",
>  "id" : 5202,
>  "name" : "spu_null_check",
>  "owner" : "test",
>  "description" : "check null value for store and category",
>  "deleted" : false,
>  "timestamp" : 1568195100000,
>  "dq.type" : "PROFILING",
>  "sinks" : [ "ELASTICSEARCH", "HDFS" ],
>  "process.type" : "BATCH",
>  "rule.description" :
> ,
>  "data.sources" : [
> Unknown macro: \{ .... }
> ],
>  "evaluate.rule" :
> ,
>  "measure.type" : "griffin"
>  },raw,raw, driverMemory: 1g, executorMemory: 6g, executorCores: 2, 
> numExecutors: 6, queue: root.users.kun_dot_wan, {color:#ff0000}*name: 
> griffin*{color}]]
> {quote}
>  
> livy Response : 
> {quote}400 Bad Request
>  [Date:"Thu, 12 Sep 2019 10:00:00 GMT", 
> Content-Type:"application/json;charset=utf-8", Content-Length:"47", 
> Server:"Jetty(9.3.24.v20180605)"]
> {"msg":"Duplicate session name: Some(griffin)"}
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to