wankunde commented on issue #536: Fix metric output URL: https://github.com/apache/griffin/pull/536#issuecomment-536378864 In my option, we can get the output metrics name from the rule configuration. For example, we can add parameter "distMetricName" or "uniqueMetricName", then we can change the dataset name to this value .if the value is null, use the default value instead. Rule json: ```json { "evaluate.rule": { "rules": [ { "dsl.type": "griffin-dsl", "dq.type": "distinct", "out.dataframe.name": "dist", "rule": "user_id", "details": { "source": "source", "target": "target", "total": "total", "distinct": "distinct", "dup": "dup", "num": "num", "duplication.array": "dup", "distMetricName": "xxxxx", "uniqueMetricName" : "yyyyyy" }, "out":[ { "type": "metric", "name": "distinct" } ] } ] } } ``` Get the output metrics name: ```scala val _distMetricName = "distMetricName" val _uniqueMetricName = "uniqueMetricName" val details = ruleParam.getDetails val distTableName = details.getString(_distMetricName, "__distMetric") val uniqueTableName = details.getString(_uniqueMetricName, "__uniqueMetric") ``` The way is more simple and compatible with previous versions. @iyuriysoft @bhlx3lyx7 How do you think about it ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
