wankunde edited a comment on issue #543: fix tests failure
URL: https://github.com/apache/griffin/pull/543#issuecomment-544800457
 
 
   Hi @ahutsunshine 
   
   I import `SparkSuiteBase` instead of spark-testing-base jar because of  
spark-testing-base jar is not compatible with some spark versions.
   
   SparkSuiteBase is mainly the same with SharedSparkContext.All the tests 
share the same SparkContext in one test suite.User can use SparkSuiteBase in 
the same way with SharedSparkContext.
   
   
https://github.com/apache/griffin/blob/e9dda8b53aadfc127854a89ac797c761b95de92a/measure/src/test/scala/org/apache/griffin/measure/SparkSuiteBase.scala
   
   
https://github.com/apache/spark/blob/484f93e25506f84d1548504783be9ce940149bb7/core/src/test/scala/org/apache/spark/SharedSparkContext.scala#L24
   
   But spark context may cache some RDD data in memory, so it needs more memory 
when running test case.The spark context will destroy and free the memory after 
all the tests is done in the test suite.
    
   So I suggest If we can remove the following VM config for Maven and see if 
the issue can be fixed.
   -Xms500m -Xmx1g -XX:MaxPermSize=256m

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to