wankunde edited a comment on issue #551: Bug fix for reflecting a custom sink object URL: https://github.com/apache/griffin/pull/551#issuecomment-554312713 Hi, @iyuriysoft The old custom sink is constructed with `SinkContext`, the user receiver parameters from the context; while the new custom sink is constructed with configuration map, it's parameter are the same parameters as `ElasticSearchSink` or `HdfsSink`, and which is easier to understand. What do you think ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
