[
https://issues.apache.org/jira/browse/GRIFFIN-297?focusedWorklogId=345152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345152
]
ASF GitHub Bot logged work on GRIFFIN-297:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/19 09:08
Start Date: 18/Nov/19 09:08
Worklog Time Spent: 10m
Work Description: wankunde commented on pull request #555: [WIP]
[GRIFFIN-297] Allow support for additional file based data sources
URL: https://github.com/apache/griffin/pull/555#discussion_r347260972
##########
File path:
measure/src/main/scala/org/apache/griffin/measure/datasource/connector/batch/FileBasedDataConnector.scala
##########
@@ -0,0 +1,162 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+ */
+package org.apache.griffin.measure.datasource.connector.batch
+
+import scala.util.{Failure, Success, Try}
+
+import org.apache.spark.sql.{DataFrame, SparkSession}
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.StructType
+
+import org.apache.griffin.measure.Loggable
+import org.apache.griffin.measure.configuration.dqdefinition.DataConnectorParam
+import org.apache.griffin.measure.context.TimeRange
+import org.apache.griffin.measure.datasource.TimestampStorage
+import org.apache.griffin.measure.utils.HdfsUtil
+import org.apache.griffin.measure.utils.ParamUtil._
+
+/**
+ * A batch data connector for file based sources which allows support various
+ * file based data sources like Parquet, CSV, TSV, ORC etc.
+ * Local files can also be read by prepending `file://` namespace.
+ *
+ * Currently supported formats like Parquet, ORC, AVRO, Text and Delimited
types like CSV, TSV etc.
+ *
+ * Supported Configurations:
+ * - format : [[String]] specifying the type of file source (parquet, orc,
etc.). Default: parquet
+ * - paths : [[Seq]] specifying the paths to be read
+ * - options : [[Map]] of format specific options
+ * - skipOnError : [[Boolean]] specifying where to continue execution if one
or more paths are invalid.
+ * - schema : [[Seq]] of {colName, colType and isNullable} given as key value
pairs. If provided, this can
+ * help skip the schema inference step for some underlying data sources.
+ */
+
+case class FileBasedDataConnector(@transient sparkSession: SparkSession,
+ dcParam: DataConnectorParam,
+ timestampStorage: TimestampStorage)
+ extends BatchDataConnector {
+
+ import FileBasedDataConnector._
+
+ val config: Map[String, Any] = dcParam.getConfig
+ var options: Map[String, String] = config.getParamStringMap(Options,
Map.empty)
+ var currentSchema: StructType = _
+
+ var format: String = config.getString(Format, DefaultFormat).toLowerCase
+ val paths: Seq[String] = config.getStringArr(Paths, Nil)
+ val schemaSeq: Seq[Map[String, String]] = config.getAnyRef[Seq[Map[String,
String]]](Schema, Nil)
+ val skipErrorPaths: Boolean = config.getBoolean(SkipErrorPaths, defValue =
false)
+
+ assert(SupportedFormats.contains(format),
+ s"Invalid format '$format' specified. Must be one of
${SupportedFormats.mkString("['", "', '", "']")}")
+
+ if (format == "csv") validateCSVOptions()
+ if (format == "tsv") format = "csv"
+
+ /**
+ * Builds a [[StructType]] from the given schema string provided as `Schema`
config.
+ *
+ * @example
+ *
{"schema":[{"name":"user_id","type":"string","nullable":"true"},{"name":"age","type":"int","nullable":"false"}]}
+ * {"schema":[{"name":"user_id","type":"decimal(5,2)","nullable":"true"}]}
+ *
{"schema":[{"name":"my_struct","type":"struct<f1:int,f2:string>","nullable":"true"}]}
+ * @return
+ */
+ private def getUserDefinedSchema: StructType = {
+ schemaSeq.foldLeft(new StructType())((currentStruct, fieldMap) => {
+ val colName = fieldMap(ColName).toLowerCase
+ val colType = fieldMap(ColType).toLowerCase
+ val isNullable =
Try(fieldMap(IsNullable).toLowerCase.toBoolean).getOrElse(true)
+
+ currentStruct.add(colName, colType, isNullable)
+ })
+ }
+
+ private def validateCSVOptions(): Unit = {
+ if (options.contains(Header) && config.contains(Schema)) {
Review comment:
`Header` should be `true`, not contains. We can check the `Schema` option
and `schemaSeq.isEmpty`, if it fails ,check `Header`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345152)
Time Spent: 1.5h (was: 1h 20m)
> Allow support for additional file based data sources
> ----------------------------------------------------
>
> Key: GRIFFIN-297
> URL: https://issues.apache.org/jira/browse/GRIFFIN-297
> Project: Griffin
> Issue Type: Improvement
> Reporter: Chitral Verma
> Priority: Major
> Labels: features
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In the current version of Apache griffin (0.5.0), there is very limited
> support for file based data sources as only Avro and Text files are
> supported.
> I propose the feature to allow support for additional file based data sources
> like Parquet, CSV, TSV, ORC etc in both batch and streaming mode. Since most
> of the above sources already have first class support provided by spark, the
> implementation is straight forward.
> Also, this feature will allow data to be read directly from stand alone files
> as well as directories present in both local and distributed filesystems.
> A sample config would look like,
> {noformat}
> {
> "name": "source",
> "baseline": true,
> "connectors": [
> {
> "type": "file",
> "version": "1.7",
> "config": {
> "format": "parquet",
> "options": {
> "k1": "v1",
> "k2": "v2"
> },
> "paths": [
> "/home/chitral/path/to/source/",
> "/home/chitral/path/to/test.parquet"
> ]
> }
> }
> ]
> }{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
