chitralverma edited a comment on issue #555: [WIP] [GRIFFIN-297] Allow support for additional file based data sources URL: https://github.com/apache/griffin/pull/555#issuecomment-555017468 > > @chitralverma > > Thanks for contribution. > > @guoyuepeng @chitralverma > > The csvReader in spark has changed since 2.4 version, but griffin still uses version 2.2.1 , I think we need more test cases for achieve compatibility. > > https://issues.apache.org/jira/browse/SPARK-25669 > > Let me add more test cases for this @wankunde I tried recreating the `SPARK-25669` bug with version 2.2.1 used by griffin but it seems like the issue exists no more. I can see in the jira that it was fixed in versions 2.3+, but right now its not appearing in version 2.2.1 I've incorporated rest of your review comments alongwith some additional code documentation to ease the use by other developers. Please review at your convenience. Thanks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
