[
https://issues.apache.org/jira/browse/GRIFFIN-312?focusedWorklogId=362396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362396
]
ASF GitHub Bot logged work on GRIFFIN-312:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 02:56
Start Date: 23/Dec/19 02:56
Worklog Time Spent: 10m
Work Description: wankunde commented on issue #560: [GRIFFIN-312] Code
Style Standardization
URL: https://github.com/apache/griffin/pull/560#issuecomment-568336509
@chitralverma
The plugin name should change with the scala version, and it has some
compatibility problems with scala 2.13.
Could you update your code?
https://issues.apache.org/jira/browse/SPARK-29293
https://github.com/apache/spark/blob/e5abbab0ed5d9d70522c1e19c53e95c631dd1565/pom.xml#L3026
scala-2.11 version:
```xml
<plugin>
<groupId>org.antipathy</groupId>
<artifactId>mvn-scalafmt_2.11</artifactId>
<version>0.12_1.5.1</version>
<configuration>
<parameters>${scalafmt.parameters}</parameters>
<skip>${scalafmt.skip}</skip>
<skipSources>${scalafmt.skip}</skipSources>
<skipTestSources>${scalafmt.skip}</skipTestSources>
<configLocation>${project.parent.basedir}/.scalafmt.conf</configLocation>
</configuration>
<executions>
<execution>
<phase>validate</phase>
<goals>
<goal>format</goal>
</goals>
</execution>
</executions>
</plugin>
```
scala-2.12 version:
```xml
<profile>
<id>scala-2.12</id>
<build>
<pluginManagement>
<plugins>
<!-- SPARK-29293 currently not able to update to 1.x for Scala
2.13 -->
<plugin>
<groupId>org.antipathy</groupId>
<artifactId>mvn-scalafmt_2.12</artifactId>
<version>0.12_1.5.1</version>
<configuration>
<parameters>${scalafmt.parameters}</parameters> <!--
(Optional) Additional command line arguments -->
<skip>${scalafmt.skip}</skip> <!-- (Optional) skip
formatting -->
<skipSources>${scalafmt.skip}</skipSources>
<skipTestSources>${scalafmt.skip}</skipTestSources>
<configLocation>dev/.scalafmt.conf</configLocation> <!--
(Optional) config location -->
</configuration>
<executions>
<execution>
<phase>validate</phase>
<goals>
<goal>format</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362396)
Time Spent: 20m (was: 10m)
> Code Style Standardization
> --------------------------
>
> Key: GRIFFIN-312
> URL: https://issues.apache.org/jira/browse/GRIFFIN-312
> Project: Griffin
> Issue Type: Improvement
> Reporter: Chitral Verma
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This issue targets to,
> * fix the various warnings during build and in source code,
> * perform code formatting as per a standard style,
> * fix scalastyle integration
> Using the [code format from spark code style can be automatically imposed on
> measure module. Link:
> [https://github.com/apache/spark/blob/master/dev/.scalafmt.conf]
> Since ScalaStyle targets scala source code only, it should be a part of the
> measure module only. Current misconfiguration is also suppressing the
> formatting errors
> Scalafmt is used for code formatting.
> Note these styles are fully configurable and can be changed at later points
> of time after discussion in dev community.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
