[ 
https://issues.apache.org/jira/browse/GRIFFIN-318?focusedWorklogId=366534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366534
 ]

ASF GitHub Bot logged work on GRIFFIN-318:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jan/20 09:17
            Start Date: 06/Jan/20 09:17
    Worklog Time Spent: 10m 
      Work Description: wankunde commented on issue #565: [GRIFFIN-318] Replace 
all YYYY with yyyy in all user guides and examples
URL: https://github.com/apache/griffin/pull/565#issuecomment-571064050
 
 
   LGTM
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 366534)
    Time Spent: 0.5h  (was: 20m)

> Replace all YYYY with yyyy in all user guides and examples
> ----------------------------------------------------------
>
>                 Key: GRIFFIN-318
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-318
>             Project: Griffin
>          Issue Type: Bug
>            Reporter: Nevena Veljkovic
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In 
> [https://github.com/apache/griffin/blob/master/griffin-doc/ui/user-guide.md]
> YYYY should be replaced with yyyy
> also DD/MM/YYYY should be replaced with dd/MM/yyyy 
> If anybody uses examples from user guide, she/he will encounter 2020-12-31 
> issue like I did
>  * Why to replace YYYY: YYYY (week year) is not necessarily equal to yyyy 
> (calendar year)
>  * Why to replace DD and YYYY in DD/MM/YYYY: DD is day of year and YYYY is 
> week year, author probable wanted to use dd (day of month) and yyyy (calendar 
> year)
> Also in 
> [https://github.com/apache/griffin/blob/master/ui/angular/src/app/measure/create-measure/configuration/configuration.component.html]
> dt=#YYYYMMdd# should be replaced with dt=#yyyyMMdd#
>  
> [https://github.com/apache/griffin/blob/master/service/src/main/java/org/apache/griffin/core/util/TimeUtil.java#L138]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to