[ 
https://issues.apache.org/jira/browse/GRIFFIN-323?focusedWorklogId=406495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406495
 ]

ASF GitHub Bot logged work on GRIFFIN-323:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/20 18:32
            Start Date: 19/Mar/20 18:32
    Worklog Time Spent: 10m 
      Work Description: pshingavi commented on issue #568: [GRIFFIN-323] 
Refactor configuration Data Source Connector
URL: https://github.com/apache/griffin/pull/568#issuecomment-601346796
 
 
   What's the compatible commit I can use in this case ? Just before this was 
merged may be ?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 406495)
    Time Spent: 1h  (was: 50m)

> Refactor configuration for Data Source and Data Source Connector
> ----------------------------------------------------------------
>
>                 Key: GRIFFIN-323
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-323
>             Project: Griffin
>          Issue Type: Improvement
>            Reporter: Chitral Verma
>            Priority: Major
>             Fix For: 0.6.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Current config structure for Data Source is as follows,
> {noformat}
>  
> "data.sources": [
>     {
>       "name": "src",
>       "connectors": [
>         {
>           "type": "AVRO",
>           "version": "1.7",
>           "config": {
>             "file.path": "<path>/<to>",
>             "file.name": "<source-file>.avro"
>           }
>         }
>       ]
>     },
>     {
>       "name": "tgt",
>       "connectors": [
>         {
>           "type": "AVRO",
>           "version": "1.7",
>           "config": {
>             "file.path": "<path>/<to>",
>             "file.name": "<target-file>.avro"
>           }
>         }
>       ]
>     }
>   ]
> {noformat}
>  
> This ticket proposes the following changes,
>  * remove 'version' from 'DataConnectorParam' as it is not being used 
> anywhere in the codebase.
>  * change 'connectors' from array type to a single JSON object. Since a data 
> source named X may only be of one type (hive, file etc), the connector field 
> should not be an array.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to