guoyuepeng commented on a change in pull request #586:
URL: https://github.com/apache/griffin/pull/586#discussion_r517019986
##########
File path: ui/angular/src/app/job/create-job/streaming/streaming.component.ts
##########
@@ -234,23 +234,21 @@ export class StreamingComponent implements OnInit {
if (measure == map.name) {
var source = map["data.sources"];
for (let i = 0; i < source.length; i++) {
- var details = source[i].connectors;
- for (let j = 0; j < details.length; j++) {
- if (details[j]["data.unit"] != undefined) {
- var table =
- details[j].config.database +
- "." +
- details[j].config["table.name"];
- var size = details[j]["data.unit"];
- var connectorname = details[j]["name"];
- var detail = {
- id: i + 1,
- name: table,
- size: size,
- connectorname: connectorname
- };
- this.dropdownList.push(detail);
- }
+ var connector = source[i].connector;
+ if (connector["data.unit"] != undefined) {
+ var table =
+ connector.config.database +
+ "." +
+ connector.config["table.name"];
+ var size = connector["data.unit"];
+ var connectorname = connector["name"];
+ var detail = {
+ id: i + 1,
+ name: table,
+ size: size,
+ connectorname: connectorname
Review comment:
> Not sure about this part
Since we have tested this from ui to service, it works from my side.
this part is ok for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
