chitralverma commented on a change in pull request #592:
URL: https://github.com/apache/griffin/pull/592#discussion_r659298650
##########
File path:
service/src/main/java/org/apache/griffin/core/metastore/hive/HiveMetaStoreProxy.java
##########
@@ -55,6 +59,28 @@ Licensed to the Apache Software Foundation (ASF) under one
private IMetaStoreClient client = null;
+ @Value("${hive.krb5conf.path}")
+ private String hiveKrb5confPath;
+
+ @Value("${hive.keytab.path}")
+ private String keytabPath;
+
+ @Value("${hive.keytab.user}")
+ private String keytabUser;
+
+ @Value("${hive.need.kerberos}")
+ private String needKerberos;
+
+ @PostConstruct
+ public void init() throws IOException {
+ if ( needKerberos != null && "true".equalsIgnoreCase(needKerberos) &&
hiveKrb5confPath != null) {
+ System.setProperty("java.security.krb5.conf", hiveKrb5confPath);
Review comment:
This can be a constant.
##########
File path:
service/src/main/java/org/apache/griffin/core/metastore/hive/HiveMetaStoreProxy.java
##########
@@ -55,6 +59,28 @@ Licensed to the Apache Software Foundation (ASF) under one
private IMetaStoreClient client = null;
+ @Value("${hive.krb5conf.path}")
+ private String hiveKrb5confPath;
+
+ @Value("${hive.keytab.path}")
Review comment:
Since kerberos doesnt apply to just hive but hadoop services in general,
the "hive." prefix can be removed from all these configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
