[ 
https://issues.apache.org/jira/browse/GRIFFIN-367?focusedWorklogId=709852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709852
 ]

ASF GitHub Bot logged work on GRIFFIN-367:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/22 11:09
            Start Date: 17/Jan/22 11:09
    Worklog Time Spent: 10m 
      Work Description: lipzhu commented on a change in pull request #596:
URL: https://github.com/apache/griffin/pull/596#discussion_r785865424



##########
File path: service/pom.xml
##########
@@ -385,7 +385,6 @@ under the License.
                 <configuration>
                     <appendAssemblyId>false</appendAssemblyId>
                     <skipAssembly>false</skipAssembly>
-                    <outputDirectory>../target</outputDirectory>

Review comment:
       The service-${version}.tar.gz location is not align with the Documention 
in 
https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md,
 or we can update the documentation to remove the confuse.  
   
   >>>It's easy to build Griffin, just run maven command mvn clean install. 
Successfully building, you can get service-${version}.tar.gz and 
measure-${version}.jar from target folder in **service** and **measure** module.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 709852)
    Time Spent: 0.5h  (was: 20m)

> Deployment guide doc update
> ---------------------------
>
>                 Key: GRIFFIN-367
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-367
>             Project: Griffin
>          Issue Type: Improvement
>            Reporter: Zhu, Lipeng
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Update deployment guide.
>  # Move the service-${version}.tar.gz from parent target folder to service 
> module target.
>  # Remove the diff change history for hive-site.xml.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to