whhe commented on a change in pull request #596:
URL: https://github.com/apache/griffin/pull/596#discussion_r785921305



##########
File path: service/pom.xml
##########
@@ -385,7 +385,6 @@ under the License.
                 <configuration>
                     <appendAssemblyId>false</appendAssemblyId>
                     <skipAssembly>false</skipAssembly>
-                    <outputDirectory>../target</outputDirectory>

Review comment:
       > The service-${version}.tar.gz location is not align with the 
Documention in 
https://github.com/apache/griffin/blob/master/griffin-doc/deploy/deploy-guide.md,
 or we can update the documentation to remove the confuse.
   > 
   > > > > It's easy to build Griffin, just run maven command mvn clean 
install. Successfully building, you can get service-${version}.tar.gz and 
measure-${version}.jar from target folder in **service** and **measure** module.
   
   You're right. I think it's better to update the doc, and the following 
commands should also be modified at the same time.
   
   ```bash
   cd $GRIFFIN_INSTALL_DIR
   tar -zxvf service-${version}.tar.gz
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to