PJ Fanning created GRIFFIN-377:
----------------------------------

             Summary: mention borrowed code in Griffin NOTICE
                 Key: GRIFFIN-377
                 URL: https://issues.apache.org/jira/browse/GRIFFIN-377
             Project: Griffin
          Issue Type: Task
            Reporter: PJ Fanning


Griffin's ThreadUtils class looks like it is derived from Apache Spark's.

https://github.com/apache/griffin/blob/9f3197cb2869f5d15a2d3b965650e22ce254f3aa/measure/src/main/scala/org/apache/griffin/measure/utils/ThreadUtils.scala#L28

https://github.com/apache/spark/blob/ae9106370a9f3002979077662149ba9122d86cef/core/src/main/scala/org/apache/spark/util/ThreadUtils.scala#L32

I think the Griffin file should mention this and that you should update your 
NOTICE file to say that you have Apache Spark derived code.

It might be a good idea to update the copyright years in your NOTICE too.

https://github.com/apache/griffin/blob/master/NOTICE





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to