whhe commented on code in PR #658: URL: https://github.com/apache/griffin/pull/658#discussion_r1688122219
########## griffin-metric/pom.xml: ########## @@ -17,24 +17,23 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; -xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> <parent> - <groupId>org.apache</groupId> - <artifactId>apache</artifactId> - <version>17</version> - <relativePath /> + <groupId>org.apache.griffin</groupId> + <artifactId>griffin</artifactId> + <version>2.0.0-SNAPSHOT</version> </parent> - <groupId>org.apache.griffin</groupId> + <groupId>org.apache.griffin.metric</groupId> Review Comment: Splitting modules makes sense to me, but I don't think it's necessary to change the group id, using different artifact id should be enough here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
