guoyuepeng commented on code in PR #673:
URL: https://github.com/apache/griffin/pull/673#discussion_r1900298183
##########
griffin-bom/pom.xml:
##########
@@ -28,16 +28,17 @@ under the License.
<version>2.0.0-SNAPSHOT</version>
</parent>
- <groupId>org.apache.griffin</groupId>
Review Comment:
The griffin-bom module is used to manage the version of third-party
dependencies. If users want to import griffin-metric to your project, they need
to import griffin-bom together by import-bom way, this can help users to manage
the version.
but for test or dev purposed dependencies, they should not declared in bom,
that means our users will import test dependencies to use griffin, that is not
necessary.
these dev or test dependencies, should be managed griffin-parent in root
pom, so all modules can use the same dev env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
