Github user bhlx3lyx7 commented on the issue:
https://github.com/apache/incubator-griffin/pull/144
Hi @xiaoqiu-vip , I think the function is great, but in the code there're
some hard codes, it's not appropriate for a common project, we recommend the
specific literals as configuration, would you please modify it first?
Furthermore, it's better to write comments in English.
Thanks.---
