[
https://issues.apache.org/jira/browse/GRIFFIN-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451877#comment-16451877
]
Lionel Liu edited comment on GRIFFIN-145 at 4/27/18 7:23 AM:
-------------------------------------------------------------
refer to [https://developer.mozilla.org/en-US/docs/Web/HTTP/Status]
Issues:
*For measure*
A. Get/update/delete measure by id & get measure by owner/ogr should have
similar response.
# for a invalid id, will response 404 not found.
# for a invalid owner/org, will response 200 ok.
B. No validation on critical field while adding measure.
# given the input as below, I also get a 201 response which indicates that the
measure is acceptable in backend.
"measure.type":"griffin",
"dq.type":"accuracy4",
"process.type":"batch4",
C. Update/delete measure response 204
# while updating or deleting a measure successfully, there response 204 with
no content. 200 with content should be better
D. Get measure names group by org will throw 500 Internal Server Error when
some measure has null organization which is not a Essential element of creating
a measure
*For jobs*
A. Geting a invalid job will response 405(Method Not Allowed), why not 404 as
well as measure service?
B. Adding a invalid job(no measure exist) will response 400(bad request), why
not 404?
C. Update/delete a job successfully response 204 with no content. 200 with
content should be better.
*For metrics*
Api are not available due to connection exception with 500, haven't tested.
*For MetaStore*
A. Get table or db metadata have same response for valid/invalid input(table),
200 OK. Why not 404 as well as job/measure for a invalid table?
was (Author: evan_wan):
refer to [https://developer.mozilla.org/en-US/docs/Web/HTTP/Status]
Issues:
*For measure*
A. Get/update/delete measure by id & get measure by owner/ogr should have
similar response.
# for a invalid id, will response 404 not found.
# for a invalid owner/org, will response 200 ok.
B. No validation on critical field while adding measure.
# given the input as below, I also get a 201 response which indicates that the
measure is acceptable in backend.
"measure.type":"griffin",
"dq.type":"accuracy4",
"process.type":"batch4",
C. Update/delete measure response 204
# while updating or deleting a measure successfully, there response 204 with
no content. 200 with content should be better
D. Get measure names group by org will throw 500 Internal Server Error when
some measure has null organization which is not a Essential element of creating
a measure
*For jobs*
A. Geting a invalid job will response 405(Method Not Allowed), why not 404 as
well as measure service?
B. Adding a invalid job(no measure exist) will response 400(bad request), why
not 404?
C. Update/delete a job successfully response 204 with no content. 200 with
content should be better.
*For metrics*
Api are not worable due to connection exception with 500, haven't tested.
*For MetaStore*
A. Get table or db metadata have same response for valid/invalid input(table),
200 OK. Why not 404 as well as job/measure for a invalid table?
> [Service] Go through service API response standard
> --------------------------------------------------
>
> Key: GRIFFIN-145
> URL: https://issues.apache.org/jira/browse/GRIFFIN-145
> Project: Griffin (Incubating)
> Issue Type: Task
> Reporter: Lionel Liu
> Assignee: wanyin
> Priority: Major
> Original Estimate: 48h
> Remaining Estimate: 48h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
