GitHub user grant-xuexu opened a pull request:
https://github.com/apache/incubator-griffin/pull/394
set the fields in configuration classes private
in configuration case classes, get*** functions are defined to access to
the fields, so for consistency, make the fields private
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grant-xuexu/incubator-griffin
feature/configuration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit 86cd21dd4ea02bed52cf37a5d5b3ff33cda0ecf0
Author: Grant Xuexu <grant.xuexu@...>
Date: 2018-07-18T13:27:46Z
replace Manifest with ClassTag
commit 67a3e05bbeb96abec6e99746b2eb4aede5f19957
Author: Grant <39704702+grant-xuexu@...>
Date: 2018-07-18T13:29:48Z
Merge pull request #1 from
grant-xuexu/feature/replace-manifest-with-classtag
replace Manifest with ClassTag
commit 301dc599d6a6d6f713d5fbecb772f2a8376f7f24
Author: Grant Xuexu <grant.xuexu@...>
Date: 2018-07-18T13:40:52Z
sync with griffin/master
commit 13e47f8509806e27a024b758c5bf4f23d49285a7
Author: grant-xuexu <grant.xuexu@...>
Date: 2018-08-13T01:42:44Z
set the fields in configuration classes private
----
---
