Github user ashutakGG commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224479994
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
- let time = new Date().getTimezoneOffset() / 60;
- let timezone = "GMT" + time + ":00";
+ let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
Looks like a hack (this and next lines). Probably worth to add a comment.
Or even extract common function as long as it happens twice in a code.
---
