[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

[bhlx3lyx7]

Github user bhlx3lyx7 commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/434#discussion_r224957455
  
    --- Diff: 
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala
 ---
    @@ -125,14 +126,20 @@ case class AccuracyExpr2DQSteps(context: DQContext,
           // 4. accuracy metric
           val accuracyTableName = ruleParam.getOutDfName()
           val matchedColName = details.getStringOrKey(_matched)
    +      val matchedFractionColName = details.getStringOrKey(_matchedFraction)
    --- End diff --
    
    As I know, UI calculates the matched fraction by total and matched count, 
in ES the metrics are just persisted in JSON format, it's OK to add a field 
here.


---