[
https://issues.apache.org/jira/browse/GRIFFIN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663256#comment-16663256
]
ASF GitHub Bot commented on GRIFFIN-203:
----------------------------------------
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/446#discussion_r228036689
--- Diff: ui/angular/src/app/measure/create-measure/raw/raw.component.html
---
@@ -0,0 +1,100 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<div class="container-fluid" (window:resize)="onResize($event)">
+ <div class="row">
+ <h5 class="over-title margin-bottom-15">Create Measure</h5>
+ </div>
+ <div class="row">
+ <form name="Form" id="form" #prForm="ngForm" novalidate>
+ <div id="wizard" class="swMain">
+ <ul>
+ <li>
+ <a class="selected">
+ <div class="stepNumber">
+ 1
+ </div>
+ <span class="stepDesc text-small"> Configuration </span>
+ </a>
+ </li>
+ </ul>
+ </div>
+ <div id="step-1" class="formStep">
+ <label class="stepDesc">Please setup the measure required
information</label>
+ <div class="container-fluid">
+ <div class="col-md-12 col-lg-12 col-sm-12">
+ <fieldset>
+ <legend>
+ Required Information
+ </legend>
+ <div class="col-md-12 col-lg-12 col-sm-12"
style="margin-top:30px;">
+ <div class="form-group"
+ [ngClass]="{'has-error': !valid, 'has-success':
valid}">
+ <div class="row">
+ <label class="col-md-2 col-lg-2 col-sm-2
control-label">
+ Raw measure<span class="symbol required"></span>:
+ </label>
+ <div class="col-md-10 col-lg-10 col-sm-10">
+ <div class="btn-group btn-group-sm navbar-right"
role="group" aria-label="Format">
+ <button type="button" class="btn btn-primary"
[ngClass]="{'active': format == Format.json}"
(click)="changeFormat(Format.json)">JSON</button>
+ <button type="button" class="btn btn-primary"
[ngClass]="{'active': format == Format.yaml}"
(click)="changeFormat(Format.yaml)">YAML</button>
+ </div>
+ </div>
+ </div>
+ <div class="row">
+ <textarea class="code-viewport" rows="20" required
[(ngModel)]="data" #content="ngModel" name="content"
(ngModelChange)="onInputChange()"></textarea>
+ <span class="error text-small block "
*ngIf="!valid">Measure is not valid</span>
+ </div>
+ </div>
+ </div>
+ <div style="color:#b2c831">
+ <p>
+ <i class="fa fa-info-circle"></i> After submitted,
please go to "<a class="bark-link"
+
routerLink="/measures">Measures</a>"
+ to check the measure status
+ </p>
+ </div>
+ </fieldset>
+ </div>
+ <div class="form-group btn-container">
+ <toaster-container></toaster-container>
+ <button type="submit" (click)="submit(prForm)" class="btn
btn-primary btn-o next-step btn-wide pull-right">
+ Submit
+ </button>
+ </div>
+ </div>
+ </div>
+ <div class="modal fade" id="confirm" role="dialog" #modal
tabindex="-1" [ngClass]="{'in': visibleAnimate}"
+ [ngStyle]="{'display': visible ? 'block' : 'none', 'opacity':
visibleAnimate ? 1 : 0}"
+ (click)="onContainerClicked($event)">
+ <div class="modal-dialog modal-xg modal-lg">
--- End diff --
Oh ok. Thanks for checking!
> "Plaintext mode" for measure creation
> -------------------------------------
>
> Key: GRIFFIN-203
> URL: https://issues.apache.org/jira/browse/GRIFFIN-203
> Project: Griffin (Incubating)
> Issue Type: New Feature
> Reporter: Nikolay Sokolov
> Priority: Major
>
> Creating custom rules from API might be cumbersome -- body should be prepared
> outside of UI, and then submitted using HTTP call. To make user's life
> easier, it would be useful to allow measure creation by editing JSON directly
> on UI. Viewing side of this feature would be GRIFFIN-202.
> Also, experience-wise, JSON might not be the best option for complex
> spark-sql rules. Possible solution to that would be allowing to write YAML
> representation instead of JSON, and then either submitting YAML body or
> converting from YAML to JSON on UI side before submission.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
