+1 Besides, I was wondering If most, if not all these static methods, should have all parameters marked as final. Is there any policy about this ? Would it help ?
2016-04-24 21:46 GMT+02:00 Jochen Theodorou <blackd...@gmx.org>: > On 24.04.2016 18:12, John Wagenleitner wrote: > >> About to merge in PR 290 [1] and wanted to do a quick poll to see if >> there were any objections since it touches quite a few files across core >> and sub-modules. Any objections to merging this into master? And >> GROOVY_2_4_X? >> >> [1] https://github.com/apache/groovy/pull/290 >> > > I guess it is ok. I did see two package private methods made private > instead of only private ones, but even those should be ok. so unless I did > oversee something I do not really have any objection here. > > bye Jochen >
