Hi John, the Spock example is fine since that isn't left as the method name by the time the test is run. I am puzzled how the other one could have ever run.
Cheers, Paul. On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner <[email protected]> wrote: > +1 > > Just wanted to note that in testing I came across some method names in tests > that had characters that are now no longer allowed in method names [1] [2]. > I know this is related to the fix for GROOVY-6792, just thought it was odd > that it seems to have worked in some cases before. > > [1] > https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groovy/org/grails/web/codecs/CodecSpec.groovy#L40 > > [2] > https://github.com/grails/grails-core/blob/521f733530160407b92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grails/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17 > > On Thu, Mar 9, 2017 at 2:29 PM, Paul King <[email protected]> wrote: >> >> Dear community, >> >> I am happy to start the VOTE thread for a Groovy 2.4.10 release! >> >> This release includes 9 bug fixes/improvements as outlined in the >> changelog: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12339743 >> >> Tag: >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_10 >> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351 >> >> The artifacts to be voted on are located as follows (r18648). >> Source release: >> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources >> Convenience binaries: >> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution >> >> Release artifacts are signed with a key from the following file: >> https://dist.apache.org/repos/dist/dev/groovy/KEYS >> >> Please vote on releasing this package as Apache Groovy 2.4.10. >> >> The vote is open for the next 72 hours and passes if a majority of at >> least three +1 PMC votes are cast. >> >> [ ] +1 Release Apache Groovy 2.4.10 >> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >> [ ] -1 Do not release Apache Groovy 2.4.10 because... >> >> Here is my vote: >> >> +1 (binding) > >
