I created an issue to track this: https://issues.apache.org/jira/browse/GROOVY-8387
On Mon, Nov 20, 2017 at 5:47 PM, Uwe Schindler <u...@thetaphi.de> wrote: > Hi, > > Yes, this is risky when you update ASM to 6.0. I had the same issue during > repackage, but I fixed it: > > https://github.com/policeman-tools/forbidden-apis/commit/ > 1654d5d38e40ee500ca7ae82b146ed6fcfba0827 > > > Am 20. November 2017 08:34:02 MEZ schrieb "Cédric Champeau" < > cedric.champ...@gmail.com>: >> >> I don't find any evidence of `module-info` file on `master` or 2.6.X. On >> the other hand, we have the ASM module-info file bundled, because we >> repackage. This is a mistake that needs to be fixed. So, false alarm, >> Daniel: WE didn't add a module-info file: a dependency of ours, ASM, has >> one, and when we create our jars it should be removed. >> >> 2017-11-20 8:28 GMT+01:00 Cédric Champeau <cedric.champ...@gmail.com>: >> >>> We should remove it: it doesn't make sense to have a module info at this >>> point, when we don't even know what we require, export, and when all of our >>> dependencies are not modules. And I'm not talking about our different >>> artifacts. If this was an experiment, it shouldn't have landed on master. >>> It will cause more harm than anything else if people try Groovy as a module. >>> >>> >>> 2017-11-20 8:20 GMT+01:00 Daniel Sun <realblue...@hotmail.com>: >>> >>>> Hi Cédric, >>>> >>>> I do not know who contributed the module-info, which seems to >>>> exist >>>> for a long time. >>>> >>>> Cheers, >>>> Daniel.Sun >>>> >>>> >>>> >>>> -- >>>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html >>>> >>> >>> >> > -- > Uwe Schindler > Achterdiek 19, 28357 Bremen > <https://maps.google.com/?q=Achterdiek+19,+28357+Bremen&entry=gmail&source=g> > https://www.thetaphi.de >
