Potential Java 7 issue: When I run the grape, groovyDoc, groovyConsole or groovysh command line tools with environment variable JAVA_HOME set to my JDK-7 installation, I see two warnings that the extensions and the static extensions for Date could not be installed.
$ groovyDoc May 22, 2018 7:52:28 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule WARNING: Module [groovy-datetime] - Unable to load extension class [org.apache.groovy.datetime.extensions.DateTimeExtensions] May 22, 2018 7:52:28 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule WARNING: Module [groovy-datetime] - Unable to load extension class [org.apache.groovy.datetime.extensions.DateTimeStaticExtensions] With groovyConsole I additionally see a warning about preferences: $ groovyConsole -h May 22, 2018 7:55:58 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule WARNING: Module [groovy-datetime] - Unable to load extension class [org.apache.groovy.datetime.extensions.DateTimeExtensions] May 22, 2018 7:55:58 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule WARNING: Module [groovy-datetime] - Unable to load extension class [org.apache.groovy.datetime.extensions.DateTimeStaticExtensions] May 22, 2018 7:55:58 AM java.util.prefs.WindowsPreferences <init> WARNING: Could not open/create prefs root node Software\JavaSoft\Prefs at root 0x80000002. Windows RegCreateKeyEx(...) returned error code 5. Is anyone else also seeing this? Remko On Tue, May 22, 2018 at 0:27 Paul King <pa...@asert.com.au> wrote: > If you run: ./gradlew rat > It should exclude all the necessary files using the excludes in > gradle/quality.gradle > (the excludes list actually has some extra entries so you can run it on > the full repo - which includes a few things we don't put in the src zip) > > As for the other tools still using commons CLI, it was intentional > originally as a way to test the legacy CliBuilder support but I think > we have that in hand now, so PRs welcome. > > I fixed the getParser typo. Thanks for spotting that. It would have still > worked but not achieved the desired outcome. > > We'll have to check all of the doco. There are numerous adoc files for > tools-groovy, tools-groovyc, groovydoc, etc. > > Cheers, Paul. > > > On Tue, May 22, 2018 at 12:04 AM, Remko Popma <remko.po...@gmail.com> > wrote: > >> +1 >> >> When building the GROOVY_2_5_X branch, I see failing RAT tests: >> >> $project/subprojects/groovy-templates/out/test/resources/ >> includes/hello-escaped.txt >> $project/subprojects/groovy-templates/out/test/resources/ >> includes/hello.html >> $project/subprojects/groovy-templates/out/test/resources/raw.txt >> $project/subprojects/groovy-templates/out/test/resources/ >> to_be_escaped.txt >> >> Not a showstopper, but can these be excluded from the RAT checks somehow? >> >> >> Other things I noticed (none of them showstoppers, I believe): >> >> Out of the command line tools in bin, three were migrated from >> commons-cli to picocli (groovy, groovyc and grape), so they show usage help >> in ANSI colors and have consistent version, help and classpath switches. >> The others (groovysh, groovyConsole and groovydoc) either explicitly >> import groovy.cli.commons.CliBuilder or implicitly import >> groovy.util.CliBuilder. This means that these tools don't show help in ANSI >> colors. Their version, help and classpath switches also look different than >> the first-mentioned tools. If this was intentional then no problem. >> Otherwise it may be good to import groovy.cli.picocli.CliBuilder so they >> all have usage help in ANSI colors, and perhaps align the switches. If >> there is interest I would like to generate auto-completion scripts for all >> tools, if they are all picocli-based that becomes easier. >> >> groovy.util.CliBuilder now has two deprecated setParser methods. I >> believe the intention is that the one on line 60 should be named getParser >> instead? >> Also, should a deprecated getter/setter for Options be added? >> >> The docs for the grape command line tool (groovy-2.5.0-rc-3/html/ >> documentation/grape.html#Grape-CommandLineTool) is a bit out of date: >> missing the uninstall subcommand and missing the classifier argument for >> the install subcommand. >> >> >> >> >> >> >> On Mon, May 21, 2018 at 4:03 AM, Jochen Theodorou <blackd...@gmx.org> >> wrote: >> >>> +1 >>> >>> On 19.05.2018 17:40, Paul King wrote: >>> >>>> >>>> Dear development community, >>>> >>>> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release! >>>> >>>> This release includes 27 bug fixes/improvements as outlined in the >>>> changelog: >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>>> projectId=12318123&version=12343166 >>>> >>>> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a= >>>> tag;h=refs/tags/GROOVY_2_5_0_RC_3 >>>> Tag commit id: 6bff836d8373ff58f27f31106e9179eb4ab6b3ad >>>> >>>> The artifacts to be voted on are located as follows (r27001). >>>> Source release: https://dist.apache.org/repos/ >>>> dist/dev/groovy/2.5.0-rc-3/sources >>>> Convenience binaries: https://dist.apache.org/repos/ >>>> dist/dev/groovy/2.5.0-rc-3/distribution >>>> >>>> Release artifacts are signed with a key from the following file: >>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS >>>> >>>> Please vote on releasing this package as Apache Groovy 2.5.0-rc-3. >>>> >>>> Reminder on ASF release approval requirements for PMC members: >>>> http://www.apache.org/legal/release-policy.html#release-approval >>>> Hints on validating checksums/signatures (but replace md5sum with >>>> sha256sum): >>>> https://www.apache.org/info/verification.html >>>> >>>> The vote is open for the next 72 hours and passes if a majority of at >>>> least three +1 PMC votes are cast. >>>> >>>> [ ] +1 Release Apache Groovy 2.5.0-rc-3 >>>> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >>>> [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because... >>>> >>>> Here is my vote: >>>> >>>> +1 (binding) >>>> >>>> >>> >> >
