Thanks Vaidotas, This only affects switches which are the last statement of the enclosing method (or script) and which have a case statement containing only a break statement and no other statements. There are some simple workarounds too: add any statement in the case or add any statement after the switch. While certainly not ideal for this regression to sneak through, since its scope is limited and workarounds simple, my current thinking is to proceed with the release and add a known issue to the release notes. There are some other important changes in the release which would be good not to hold up but we should plan for a 2.5.11 release shortly. Users can examine any known issues and decide whether it will likely impact them or whether they should wait until the next release.
Cheers, Paul. On Thu, Mar 5, 2020 at 7:15 PM Vaidotas Valuckas <vvaluc...@gradle.com> wrote: > Hello, > > I found a regression in a fix to GROOVY-9424 that breaks compilation of > switch statements in certain cases. > Commented on https://issues.apache.org/jira/browse/GROOVY-9424 with > details. > > > Kind regards, > Vaidotas > > On 2020/03/03 13:35:11, Paul King <p...@asert.com.au> wrote: > > Here is the real content!> > > > > ------------------------> > > > > Dear development community,> > > > > I am happy to start the VOTE thread for a Groovy 2.5.10 release!> > > > > This release includes 12 bug fixes/improvements as outlined in the> > > changelog:> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12346773> > > > > > Tag:> > > > https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_10> > > > Tag commit id: fb068ef1829a98bc989eb438fe3e299071c17b5d> > > > > The artifacts to be voted on are located as follows (r38368).> > > Source release: > https://dist.apache.org/repos/dist/dev/groovy/2.5.10/sources> > > Convenience binaries:> > > https://dist.apache.org/repos/dist/dev/groovy/2.5.10/distribution> > > > > Release artifacts are signed with a key from the following file:> > > https://dist.apache.org/repos/dist/dev/groovy/KEYS> > > > > Please vote on releasing this package as Apache Groovy 2.5.10.> > > > > Reminder on ASF release approval requirements for PMC members:> > > http://www.apache.org/legal/release-policy.html#release-approval> > > Hints on validating checksums/signatures (but replace md5sum with> > > sha256sum):> > > https://www.apache.org/info/verification.html> > > > > The vote is open for the next 72 hours and passes if a majority of at > least> > > three +1 PMC votes are cast.> > > > > [ ] +1 Release Apache Groovy 2.5.10> > > [ ] 0 I don't have a strong opinion about this, but I assume it's ok> > > [ ] -1 Do not release Apache Groovy 2.5.10 because...> > > > > Here is my vote:> > > > > +1 (binding)> > > > > On Tue, Mar 3, 2020 at 11:33 PM Paul King <pa...@asert.com.au> wrote:> > > > > >> > > >> > > >
