On 2020-08-03 14:12, Paul King wrote: > I am inclined to do a fresh start since as others have pointed out we do > have the old repo. The old code is 3-clause BSD license but this > contribution is being made under Apache license. Also, the code was > refactored somewhat to be more consistent with the current code base > styling and tweaked to work better with Groovy 3 and CompileStatic.
That's sounds sensible for me to keep it with just one commit. Regarding Guillaume Laforge's comment: > Now that said, perhaps some of our ASF INFRA admins have some > super git abilities and know how to import some external sources with their > history? Having a similar issue in the future you can let me know. I've already did that trick a few times with different projects that started in separate repos and were merged later on into submodules of some other project. Marcin > On Mon, Aug 3, 2020 at 10:01 PM Guillaume Laforge <glafo...@gmail.com> > wrote: > >> Agreed, but 1) it's definitely not the same size of project (only 300 >> commits for GContracts), and 2) the history is not lost since it stays in >> the old project (even if it's less convenient to have to dig in another >> location). Now that said, perhaps some of our ASF INFRA admins have some >> super git abilities and know how to import some external sources with their >> history? >> >> On Mon, Aug 3, 2020 at 12:26 PM Jochen Theodorou <blackd...@gmx.org> >> wrote: >> >>> On 03.08.20 11:50, Guillaume Laforge wrote: >>> [...] >>>> And honestly, it's pretty rare that we have to dig in anyway. >>> >>> that could be true in case of gcontracts. >>> For groovy-core it certainly is not true. Especially if the code part I >>> am looking at is unfamiliar it is very important to get why some things >>> are how they are. That is also why it was so important to have all the >>> old codehaus issues in apache. >>> >>> bye Jochen >>> >>> >> >> -- >> Guillaume Laforge >> Apache Groovy committer >> Developer Advocate @ Google Cloud Platform >> >> Blog: http://glaforge.appspot.com/ >> Twitter: @glaforge <http://twitter.com/glaforge> >> > -- https://blog.solidsoft.pl/ - Working code is not enough
