Eric, To me GROOVY-8551 seems more about our internal design and doesn't seem to directly impact users?
GROOVY-10381 might warrant a re-roll of the release but does seem a fairly rare edge case? Do you think we could release-note the known issue and fix for next time? That would let us get feedback on other changes like the Jakarta Servlet changes in the meantime. There could easily be things for that which need fixing too. Thoughts? Paul. On Thu, Jan 23, 2025 at 7:52 AM Milles, Eric (TR Technology) via dev <dev@groovy.apache.org> wrote: > > I noticed a couple issues with this release: > > GROOVY-10381 (duplicate interface default methods): > > the location of the error ends up at line -1 of the offending source file > the override scenario given in the first comment was not tested and actually > results in an error for "inheriting unrelated default methods" > > Thus, the change is a breaking one for any class that overrides an interface > default method that is duplicated by another interface > > > > GROOVY-8551 (array initializer parser changes) > > commit > https://github.com/apache/groovy/commit/3084279cd93cc541a625ae5f4f29d9fc48844498 > is described as "simplify parser rules for array" > > This change came in on the 21st without any review or notification > This change was not linked on the cited issue ticket > This change reverts specific, intentional changes designed to make the > parser/recognizer and AST builder faster/simpler > No new issue was created to describe or trach the shortcomings of the > previous solution or the discussion for the new solution > > > ________________________________ > From: Paul King <pa...@asert.com.au> > Sent: Tuesday, January 21, 2025 4:44 PM > To: Groovy_Developers <dev@groovy.apache.org> > Subject: [EXT] [VOTE] Release Apache Groovy 5.0.0-alpha-12 > > External Email: Use caution with links and attachments. > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 5.0.0-alpha-12 release! > > This release includes 34 bug fixes/improvements as outlined in the changelog: > https://urldefense.com/v3/__https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12355273__;!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRve9VMG0nw$ > > Tag: > https://urldefense.com/v3/__https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs*tags*GROOVY_5_0_0_ALPHA_12__;Ly8!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRveAd5nq1g$ > Tag commit id: 0bacabbaebb63a3b388471d7a63153e3984ce5c5 > > The artifacts to be voted on are located as follows (r74346). > Source release: > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/groovy/5.0.0-alpha-12/sources__;!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRvcCnnMnxA$ > Convenience binaries: > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/groovy/5.0.0-alpha-12/distribution__;!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRve-0bHwHQ$ > > Release artifacts are signed with a key from the following file: > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/release/groovy/KEYS__;!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRvd4XZoiGw$ > > Please vote on releasing this package as Apache Groovy 5.0.0-alpha-12. > > Reminder on ASF release approval requirements for PMC members: > https://urldefense.com/v3/__http://www.apache.org/legal/release-policy.html*release-approval__;Iw!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRvcd-bVvvg$ > Hints on validating checksums/signatures (but replace md5sum with sha256sum): > https://urldefense.com/v3/__https://www.apache.org/info/verification.html__;!!GFN0sa3rsbfR8OLyAw!Z4_rVI5LKdhBKcFOeQjSVX_WLRPRMyMrsDFj0spIKXiCOHkEJ8Qt70r-wZ1fZcOJGEvHONWPw0ojRvcEitORnA$ > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release Apache Groovy 5.0.0-alpha-12 > [ ] 0 I don't have a strong opinion about this, but I assume it's ok > [ ] -1 Do not release Apache Groovy 5.0.0-alpha-12 because... > > Here is my vote: > > +1 (binding)
