Actually Kafka doesn't download the wrapper. The README tells you to download Gradle and install the wrapper. And there's no guarantee that it will be the same version. And that's what I mean by "defeating the concept". If you have to have a build script for Windows and *nix that downloads the wrapper which is itself meant to download the right version of Gradle so that you guarantee that you can build on the right version of the tool, it's a total non-sense. Why not having a script that downloads the script that downloads the script to download the wrapper? :)
Not being able to include the wrapper in the source release is a big step backwards. Anyway if we cannot keep it in the source zip (which would be very unfortunate) I would rather vote on keeping it in Git, and when we do a release not include it and instead generate a README that tells you *which* version of Gradle to install to be able to reproduce the build. 2015-04-16 7:06 GMT+02:00 Roman Shaposhnik <[email protected]>: > On Wed, Apr 15, 2015 at 11:53 PM, Andrew Bayer <[email protected]> > wrote: > > Kafka downloads the wrapper jar at build time - > > https://github.com/apache/kafka/ > > <https://github.com/apache/kafka/blob/0.8.2/gradlew> - that's probably > the > > route we should take. > > I believe Bigtop is doing a similar thing and I agree -- that's the > preferred path. > > Thanks, > Roman. >
