Thanks, just wanted to know it was seen. I absolutely sympathize with the concern having been in that position myself in other products. It certainly looks wonky. My own comfort comes mostly from the fact that the eval+exec trick is patterned off of the tomcat project's launch scripts. I take no issue with people being cautious and thorough in review. I am in no rush.
Thanks again. --Jeff On Mon, May 11, 2015 at 9:48 AM, Cédric Champeau <[email protected]> wrote: > Hi Jeff > > Sorry for not commenting on the PR yet. Basically we're very conservative > regarding changes to run scripts, because it's easy to break things. We > don't have any integration test that would make sure we don't break > something, so we'll have to check what your PR implies in terms of > compatibility. > > 2015-05-11 15:33 GMT+02:00 Jeff Adamson <[email protected]>: > >> I filed a bug along with a patch and github pull request a few weeks >> back. This was around the time of the migration to apache, but seems to >> have everything in the correct place. >> >> https://issues.apache.org/jira/browse/GROOVY-7378 >> https://github.com/apache/incubator-groovy/pull/5 >> >> I see other pull requests that have been merged and closed. What is the >> best way to get feedback on my patch and/or merge it in? >> >> --Jeff >> > >
