Thanks for the feedback guys. :)
I deleted GroovyJarTest.jar and the test using it (SignedJarTest.java)
from the repo.
I'm not able to fix the other disabled security test, but I will not
delete them either. Maybe somebody else is able to fix them later on.
After this change there are no more jars in the source distribution.
Cheers,
Pascal
Am 26.06.2015 um 10:01 schrieb Cédric Champeau:
2015-06-18 7:38 GMT+02:00 Paul King <[email protected]
<mailto:[email protected]>>:
We should keep the security tests. When converting from Ant to
Gradle we never got
around to making those tests work. We should. We'd no doubt have
users relying on
some of Groovy's special security handling. From memory the
groovy.policy file has
entries like: "file:${user.dir}/target/classes/-" in it but when
running from IDEA
it might need to be something like: "file:${user.dir}/out/test/-"
and maybe
"out/production" as well ... and different again for Gradle and
possibly trickier?
We might be just able to call out to Ant if that is easier.
But +1 though on getting rid of GroovyJarTest.jar if we can - if
we can keep
roughly the same functionality.
Yes, getting rid of GroovyJarTest is ok now. But obviously all
security tests are just totally broken. The way they are configured,
as well as the way they are activated
are totally wrong. There's not a single chance that they work today.
Cheers, Paul.
On 15/06/2015 5:01 AM, Pascal Schumacher wrote:
Hello everybody,
what about removing "/security" and "src/test/groovy/security"
from the repo?
They are just a few test and it looks like no work has been
done on them since 2007.
Security Test are not run in the Groovy Gradle build since
20.03.2012. I do not know if they ran in the old Ant build.
Not a single test succeeds at the moment when I run them in
IntelliJ.
What do you think?
Cheers,
Pascal
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
