good idea, I'll do that when I get a chance On Mon, Jul 13, 2015 at 11:02 PM, keeganwitt <[email protected]> wrote:
> Github user keeganwitt commented on a diff in the pull request: > > > https://github.com/apache/incubator-groovy/pull/59#discussion_r34459936 > > --- Diff: src/test/groovy/tree/NavigationTest.groovy --- > @@ -57,11 +65,25 @@ class NavigationTest extends GroovyTestCase { > } > b5() > } > - > assert root != null > - > - println(root) > - > return root > } > + > + private static createTreeFromXmlParser() { > + def xml = ''' > + <root> > + <parent1> > + <childa/> > + <childb/> > + </parent1> > + <parent2> > + <childa/> > --- End diff -- > > I think it'd improve this test to have all nodes uniquely named. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
