GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-client/pull/219

    GUACAMOLE-363: Do not declare custom types as default "NOT NULL".

    By defining custom types with `NOT NULL`, columns which use those types 
default to being `NOT NULL` rather that the standard default of being nullable. 
With recent reformatting of the SQL scripts to match the style of the MySQL / 
PostgreSQL scripts, this causes inserts to fail for some tables where `NULL` 
values are meant to be allowed.
    
    The `NOT NULL` qualifier should be removed from the custom types, with the 
schema instead relying on explicit specification of `NOT NULL` in the column 
definition.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-client 
fix-sqlserver-types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #219
    
----
commit b0553d5f16de9bea527013d978ff87d11d7396df
Author: Michael Jumper <[email protected]>
Date:   2017-12-12T07:47:23Z

    GUACAMOLE-363: Do not declare custom types as default "NOT NULL". Rely on 
column definitions for such semantics.

----


---

Reply via email to