Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/132#discussion_r161148445
  
    --- Diff: src/terminal/display.c ---
    @@ -317,6 +319,9 @@ guac_terminal_display* 
guac_terminal_display_alloc(guac_client* client,
     
     void guac_terminal_display_free(guac_terminal_display* display) {
     
    +    /* Free default palette. */
    +    free((void*) display->default_palette);
    --- End diff --
    
    Not necessarily a request for a change, but I am curious: is this 
necessary? This is the first I've seen an explicit typecast to `(void*)` for a 
call to `free()`.


---

Reply via email to