Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/224#discussion_r161385948
--- Diff:
guacamole/src/main/webapp/app/client/controllers/clientController.js ---
@@ -64,16 +65,23 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
*/
var MENU_DRAG_VERTICAL_TOLERANCE = 10;
- /*
+ /**
* In order to open the guacamole menu, we need to hit ctrl-alt-shift.
There are
* several possible keysysms for each key.
*/
var SHIFT_KEYS = {0xFFE1 : true, 0xFFE2 : true},
ALT_KEYS = {0xFFE9 : true, 0xFFEA : true, 0xFE03 : true,
0xFFE7 : true, 0xFFE8 : true},
CTRL_KEYS = {0xFFE3 : true, 0xFFE4 : true},
+ END_KEYS = {0xFF57 : true, 0xFFB1 : true},
--- End diff --
As the comment for this set of declarations deals specifically with
Ctrl+Alt+Shift, I suggest not including this declaration here, but rather
separating it like you did with `DEL_KEY`.
---
