Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/204#discussion_r161386243
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
---
@@ -124,10 +126,15 @@ private String getUserBindDN(String username)
}
// Return the single possible DN
- return userDNs.get(0);
+ return new Dn(userDNs.get(0));
--- End diff --
Should `getUserDNs()` be returning `List<Dn>` or similar instead of
`List<String>`? There may be a way to update `getUserDNs()` such that we aren't
converting `Dn` to `String` and back to `Dn`.
---
