Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/122#discussion_r161413713
  
    --- Diff: 
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/RadiusChallengeResponseField.java
 ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.auth.radius.form;
    +
    +import org.apache.guacamole.form.Field;
    +import org.codehaus.jackson.annotate.JsonProperty;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * A form used to prompt the user for additional information when
    + * the RADIUS server sends a challenge back to the user with a reply
    + * message.
    + */
    +public class RadiusChallengeResponseField extends Field {
    +
    +    /**
    +     * The field returned by the RADIUS challenge/response.
    +     */
    +    public static final String PARAMETER_NAME = 
"guac-radius-challenge-response";
    +
    +    /**
    +     * The type of field to initialize for the challenge/response.
    +     */
    +    private static final String RADIUS_FIELD_TYPE = 
"GUAC_RADIUS_CHALLENGE_RESPONSE";
    +
    +    /**
    +     * The message the RADIUS server sent back in the challenge.
    +     */
    +    private final String replyMsg;
    +
    +    /**
    +     * Initialize the field with the reply message and the state.
    +     */
    +    public RadiusChallengeResponseField(String replyMsg) {
    +        super(PARAMETER_NAME, RADIUS_FIELD_TYPE);
    +        this.replyMsg = replyMsg;
    +
    +    }
    +
    +    /**
    +     * Get the value of the replyMsg field.
    --- End diff --
    
    "Get the value of the replyMsg field" describes the what this function 
might be used to do using terminology which refers to the internals of the 
class. Please instead describe what this function does from the perspective of 
the caller.


---

Reply via email to