GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-client/pull/227
GUACAMOLE-161: Handle known platform/browser keyboard quirks semantically.
This change adds a new private set of boolean flags within
`Guacamole.Keyboard` which tracks whether certain platform-specific and
browser-specific quirks are present, particularly those which can be reliably
detected only through platform/browser-sniffing, specifically:
* Whether keyup events cannot really be relied upon at all (they are
randomly dropped on iOS)
* Whether the keyup event is specifically unreliable for Caps Lock (a quirk
of the Mac OS X event model, as noted by @flangelo in #209:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#Special_cases)
* Whether the "Alt" key is safe to allow through to the browser, as it
never represents a keyboard shortcut.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-client keyboard-quirks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #227
----
commit 10f200b5301177ec24e26470977252943258120c
Author: Michael Jumper <mjumper@...>
Date: 2018-01-15T04:35:45Z
GUACAMOLE-161: Semantically represent platform/browser key event quirks.
commit 67df92eabd4546b3b481b0b9478c9b5d80d6b2c4
Author: Michael Jumper <mjumper@...>
Date: 2018-01-15T04:44:22Z
GUACAMOLE-161: Do not rely on receiving keyup for Caps Lock on Mac (only
keydown is dispatched).
----
---
