GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-server/pull/139
GUACAMOLE-352: Clean up keymap lookup/update logic for sake of
verifiability.
Historically, Guacamole's RDP support has used macros to read and write key
definitions within keymaps and similar structures. These macros are difficult
to read, difficult to verify, and frequently result in false positives in
static analysis builds due to the way each keysym is mapped.
This change replaces these macros with well-documented functions, as well
as a more straightforward and explicit mapping scheme. Internal storage of the
keymap and current key state has also been unified such that only one set of
functions is necessary to address both.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-server
clean-keymap-logic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-server/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit 053d9d420c17c52e51bb10f84036fa4e4828757d
Author: Michael Jumper <mjumper@...>
Date: 2018-01-29T06:50:11Z
GUACAMOLE-352: Clean up keymap lookup/update logic for sake of
verifiability.
----
---
