Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/252#discussion_r166861642
--- Diff:
guacamole-common/src/main/java/org/apache/guacamole/GuacamoleException.java ---
@@ -68,5 +68,15 @@ public GuacamoleException(Throwable cause) {
public GuacamoleStatus getStatus() {
return GuacamoleStatus.SERVER_ERROR;
}
+
+ /**
+ * Returns the numeric HTTP status code associated with this exception.
--- End diff --
I think the semantics of the value returned here need to be more clearly
defined. With `GuacamoleStatus`, for example, `getHttpStatusCode()` is defined
as returning "the most applicable HTTP error code". In this case, we should be
clear that the HTTP status code should be the nearest equivalent to the status
represented by this exception.
---
