Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/153#discussion_r170126687
  
    --- Diff: src/protocols/ssh/ttymode.h ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +#ifndef GUAC_SSH_TTYMODE_H
    +#define GUAC_SSH_TTYMODE_H
    +
    +#include "config.h"
    +
    +#define TTY_OP_END 0
    +#define TTY_OP_VERASE 3
    --- End diff --
    
    Unless there is a technical reason to do otherwise, global macros/variables 
need to be namespaced (in this case, I assume that would be `GUAC_SSH_`).


---

Reply via email to