Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/255#discussion_r171997077
  
    --- Diff: 
guacamole/src/main/webapp/app/navigation/services/userPageService.js ---
    @@ -60,9 +60,13 @@ angular.module('navigation').factory('userPageService', 
['$injector',
          * @returns {PageDefinition}
          *     The user's home page.
          */
    -    var generateHomePage = function generateHomePage(rootGroups) {
    +    var generateHomePage = function 
generateHomePage(rootGroups,permissions) {
     
             var homePage = null;
    +        var settingsPages = generateSettingsPages(permissions);
    +
    +        if (settingsPages.length > 1)
    --- End diff --
    
    I'm generally OK with this check (and honestly can't think of a better 
way), but please include a comment to document what's going on here. The need 
for this check is not inherently clear.


---

Reply via email to