Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/261#discussion_r172060624
  
    --- Diff: guacamole-common-js/src/main/webapp/modules/OnScreenKeyboard.js 
---
    @@ -455,6 +455,17 @@ Guacamole.OnScreenKeyboard = function(layout) {
     
         };
     
    +    /**
    +     * Resets the state of this keyboard, releasing all keys, and firing 
keyup
    +     * events for each released key.
    +     */
    +    this.reset = function() {
    --- End diff --
    
    Though historical code has not followed this, please define a name for the 
function:
    
        this.reset = function reset() {
            ...
        };
    
    This is being done for all new code as doing otherwise results in 
unreadable stack traces.


---

Reply via email to