Github user uvtrip commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/194#discussion_r174033036
  
    --- Diff: 
guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java ---
    @@ -50,6 +50,16 @@
          */
         public static final String CLIENT_ADDRESS_TOKEN = 
"GUAC_CLIENT_ADDRESS";
     
    +    /**
    +     * The token that triggers prompts for numeric fields.
    +     */
    +    public static final String PROMPT_TOKEN_NUMERIC = "-1";
    +
    +    /**
    +     * The token that triggers prompts for string fields.
    +     */
    +    public static final String PROMPT_TOKEN_STRING = "GUAC_PROMPT";
    --- End diff --
    
    In case the whole string needs to be prompt for, maybe you can also check 
for null values
    (same for numeric field as well)
    instead of hardcoded -1 or string?


---

Reply via email to