Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/156#discussion_r178541081
  
    --- Diff: src/protocols/ssh/ssh.c ---
    @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) {
     
         }
     
    +    /* Set up the ttymode array prior to requesting the PTY */
    +    if (guac_ssh_ttymodes_init(ssh_ttymodes, sizeof(ssh_ttymodes),
    +            num_tty_opcodes, (guac_ssh_ttymode){ GUAC_SSH_TTY_OP_VERASE, 
settings->backspace}))
    --- End diff --
    
    Refactored the `guac_ssh_ttymodes_init()` function.  I may have introduced 
some other bugs or conditions that need to be handled, so let me know what you 
think about it.


---

Reply via email to