Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/271#discussion_r181179697
  
    --- Diff: 
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractAuthenticationProvider.java
 ---
    @@ -0,0 +1,157 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.net.auth;
    +
    +import org.apache.guacamole.GuacamoleException;
    +
    +/**
    + * Base implementation of AuthenticationProvider which provides default
    + * implementations of most functions. Implementations must provide their
    + * own {@link #getIdentifier()}, but otherwise need only override an 
implemented
    + * function if they wish to actually implement the functionality defined 
for
    + * that function by the AuthenticationProvider interface.
    + */
    +public abstract class AbstractAuthenticationProvider implements 
AuthenticationProvider {
    +
    +    /**
    +     * {@inheritDoc}
    +     *
    +     * <p>This implementation simply returns <tt>null</tt>. 
Implementations that
    --- End diff --
    
    Use of `<tt>` might be legacy, though... It's used for `putAll()` above, 
but the actual docs for javadoc specify `<code>` or `{@code ...}`:
    
    
https://docs.oracle.com/javase/1.5.0/docs/tooldocs/windows/javadoc.html#%7B@code%7D


---

Reply via email to