Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/181#discussion_r182714041
--- Diff:
extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java
---
@@ -131,7 +141,14 @@ public static GuacamoleConfiguration
getConfiguration(String uri)
if (paramList != null) {
for (String parameter : paramList) {
String[] paramArray = parameter.split("=", 2);
- qcConfig.setParameter(paramArray[0],paramArray[1]);
+ try {
+ qcConfig.setParameter(URLDecoder.decode(paramArray[0],
"UTF-8"),
--- End diff --
If I do that, though, don't I lose the ability to tell the difference
between the "&" characters that separate the various parameters from one
another and the ones that might be encoded in a parameter name or value? Same
with the "=" characters - seems like I would lose the ability to tell the
difference between a "=" that separates a parameter name from a value and one
that's encoded as part of the parameter name or value?
---
